Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misconf): Add terraformplan support #4342

Merged
merged 5 commits into from
May 29, 2023
Merged

feat(misconf): Add terraformplan support #4342

merged 5 commits into from
May 29, 2023

Conversation

simar7
Copy link
Member

@simar7 simar7 commented May 11, 2023

Description

Adds support to scan terraformplan files.

Related issues

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@simar7 simar7 force-pushed the support-terraformplan branch 3 times, most recently from 365a502 to 82e2fb4 Compare May 17, 2023 23:05
@simar7 simar7 force-pushed the support-terraformplan branch 2 times, most recently from ddbaca1 to 6b73519 Compare May 24, 2023 02:38
@simar7 simar7 self-assigned this May 24, 2023
@simar7 simar7 marked this pull request as ready for review May 24, 2023 02:41
@simar7 simar7 requested a review from knqyf263 as a code owner May 24, 2023 02:41
@simar7 simar7 force-pushed the support-terraformplan branch from 6b73519 to e5befe8 Compare May 24, 2023 20:22
@simar7
Copy link
Member Author

simar7 commented May 24, 2023

@knqyf263 - I've updated the tests and rebased. Could you take a look?

github.com/aquasecurity/defsec v0.88.1
github.com/aquasecurity/defsec v0.88.2-0.20230516215146-673ff3afe374
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: update to latest when #4474 is merged

Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We need to resolve a conflict, though.

simar7 added 5 commits May 29, 2023 09:52
Fixes: #4341

Signed-off-by: Simar <simar@linux.com>
Signed-off-by: Simar <simar@linux.com>
Signed-off-by: Simar <simar@linux.com>
Signed-off-by: Simar <simar@linux.com>
@simar7 simar7 force-pushed the support-terraformplan branch from e5befe8 to 19462de Compare May 29, 2023 18:05
@simar7
Copy link
Member Author

simar7 commented May 29, 2023

LGTM. We need to resolve a conflict, though.

Will fix that. Need this PR to be merged first #4474 and then I'll rebase this one.

@simar7 simar7 merged commit 6fcd153 into main May 29, 2023
@simar7 simar7 deleted the support-terraformplan branch May 29, 2023 20:48
@simar7
Copy link
Member Author

simar7 commented May 29, 2023

LGTM. We need to resolve a conflict, though.

Will fix that. Need this PR to be merged first #4474 and then I'll rebase this one.

I realized its easier to rebase the other one on top of this. I'll merge this and rebase the other.

AnaisUrlichs pushed a commit to AnaisUrlichs/trivy that referenced this pull request Aug 10, 2023
* feat(misconf): Add terraformplan support

Fixes: aquasecurity#4341

Signed-off-by: Simar <simar@linux.com>

* update defsec

* fix lint

Signed-off-by: Simar <simar@linux.com>

* remove debug prints

Signed-off-by: Simar <simar@linux.com>

* update tests

Signed-off-by: Simar <simar@linux.com>

---------

Signed-off-by: Simar <simar@linux.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Trivy does not support terraformplan files
2 participants